Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: a single chip defaults to having a margin-left #4359

Closed
willshowell opened this issue May 2, 2017 · 1 comment · Fixed by #4366
Closed

Bug: a single chip defaults to having a margin-left #4359

willshowell opened this issue May 2, 2017 · 1 comment · Fixed by #4366
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@willshowell
Copy link
Contributor

willshowell commented May 2, 2017

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Single chips have no margin

What is the current behavior?

in dir=LTR

If there are two chips, the first has no left margin, and the second has no right margin.
However, a single chip has a left margin of 3px and no right margin.

What are the steps to reproduce?

http://plnkr.co/edit/1LocpntStWpV0BBI5OLj?p=preview

Motivation

When you are adding chips over time, the whole list jumps left 3px when chip count grows from 1 to 2.

Other

Due to the fallback for :last-child

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label May 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue May 2, 2017
* Fixes single chips having a left margin.
* Reduces the amount of CSS used to set up the chip margins.

Fixes angular#4359.
@crisbeto crisbeto self-assigned this May 2, 2017
@crisbeto crisbeto added the has pr label May 2, 2017
andrewseguin pushed a commit that referenced this issue May 2, 2017
* Fixes single chips having a left margin.
* Reduces the amount of CSS used to set up the chip margins.

Fixes #4359.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants