Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #4320 #4326

Merged
merged 4 commits into from
May 4, 2017
Merged

fixes #4320 #4326

merged 4 commits into from
May 4, 2017

Conversation

jdell64
Copy link
Contributor

@jdell64 jdell64 commented Apr 28, 2017

Made the fixes in #4320

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Apr 28, 2017
@jdell64
Copy link
Contributor Author

jdell64 commented Apr 28, 2017

This is the first time I've tried to contribute, so I am not sure how to update the tests. In addition, the screenshots look the same??

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Apr 28, 2017
@willshowell
Copy link
Contributor

The screenshot tests are sensitive to even those slight changes in color. AFAIK one of the team members can bypass the failure to say that the change was intentional and correct.

@@ -31,7 +31,7 @@
}

.mat-tab-label, .mat-tab-link {
color: currentColor;
color: mat-color($foreground, text);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove this space here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still got the space in there ;) You removed a space from the wrong spot

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just remove that space. Thanks for making this change

@jdell64
Copy link
Contributor Author

jdell64 commented May 2, 2017

I hope I got it this time lol

@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label May 3, 2017
@andrewseguin andrewseguin merged commit c37a2de into angular:master May 4, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants