-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #4320 #4326
fixes #4320 #4326
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
This is the first time I've tried to contribute, so I am not sure how to update the tests. In addition, the screenshots look the same?? |
CLAs look good, thanks! |
The screenshot tests are sensitive to even those slight changes in color. AFAIK one of the team members can bypass the failure to say that the change was intentional and correct. |
src/lib/tabs/_tabs-theme.scss
Outdated
@@ -31,7 +31,7 @@ | |||
} | |||
|
|||
.mat-tab-label, .mat-tab-link { | |||
color: currentColor; | |||
color: mat-color($foreground, text); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove this space here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still got the space in there ;) You removed a space from the wrong spot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just remove that space. Thanks for making this change
I hope I got it this time lol |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Made the fixes in #4320