-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): export MdOptionSelectionChange #4285
Conversation
@jelbourn Any thoughts on this? I also just found that Are these exports considered internal if they aren't exported again in My use case is our search bar which is a mix of auto complete and "Chip" style tag/field suggestions. Kind of similar to gitlab's tag suggestions in their issue search. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@crisbeto Can I export |
I'll double check whether it's something we'd want to export. It might be more appropriate as a part of #4290 though. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This exports
MdOptionSelectionChange
in@angular/material
. It makes it easier to import if you are making a custom component which usesmdOption
and needs to handle selection changes itself(ie a custom search bar).I couldn't find any guidelines on when or why certain things are exported but not exposed in the main
@angular/material
package.Feel free to close if we should just import fromIt seems importing from@angular/material/core/option
instead.@angular/material/core/option
doesn't work even though there are type files.