Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ripple): global ripple configuration on init #4238

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

devversion
Copy link
Member

  • Currently when no bindings are set on the mdRipple target, the ngOnChanges will not fire and the global ripple options will be ignored forever.

Fixes #4235

* Currently when no bindings are set on the `mdRipple` target, the `ngOnChanges` will not fire and the `globalRippleOptions` will be ignored forever.

Fixes angular#4235
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 24, 2017
@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Apr 24, 2017
@mmalerba mmalerba merged commit 9a2c4d6 into angular:master Apr 25, 2017
@devversion devversion deleted the fix/ripple-global-conf branch May 4, 2017 17:05
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling ripple globally does not work on tabs.
3 participants