Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(checkbox): hover mouse pointer cursor #4185

Closed
OvidijusStukas opened this issue Apr 20, 2017 · 5 comments · Fixed by #4473
Closed

Bug(checkbox): hover mouse pointer cursor #4185

OvidijusStukas opened this issue Apr 20, 2017 · 5 comments · Fixed by #4473
Assignees
Labels
help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@OvidijusStukas
Copy link

What is the expected behavior?

Currently when hovering on checkbox'es the mouse cursor does not change.

What is the current behavior?

To be same as Material1 and change mouse cursor to pointer

Which versions of Angular, Material, OS, browsers are affected?

Angular 4.0.1,
Windows 10,
Chrome 57

@devversion
Copy link
Member

devversion commented Apr 20, 2017

It looks like I did this intentionally because native inputs don't do it either.

See SHA 3edf105

Also buttons don't have a cursor by default - read here.

I personally think that the cursor on the checkbox makes sense. (Similar as we have it for our buttons)

@jelbourn
Copy link
Member

jelbourn commented Apr 20, 2017

My stance is that the cursor should match the behavior of the corresponding native element, which in this case is the default cursor.

@GaryB432
Copy link

GaryB432 commented May 5, 2017

hi... I'm seeing the pointer over the label but default over the checkbox itself. Is that the intention?

e.g. <md-checkbox [checked]="true">Pointer Cursor Here</md-checkbox>

@jelbourn
Copy link
Member

After chatting with someone on the Material Design team, I changed my mind and agree we should do cursor.

@jelbourn jelbourn reopened this May 10, 2017
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion and removed discussion labels May 10, 2017
devversion added a commit to devversion/material2 that referenced this issue May 11, 2017
* Adds the pointer cursor to the whole checkbox layout to also indicate that you can also click on the checkbox container and not only on the label.

Fixes angular#4185
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants