Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide-toggle): remove unused mousedown listener #4184

Merged
merged 1 commit into from
Apr 21, 2017

Conversation

devversion
Copy link
Member

Removes the unused setMousedown listener for the temporary ripples.

The slide-toggle now uses the real MdRipple service and therefore the listener is unnecessary.

* Removes the unused `setMousedown` listener for the temporary ripples. The slide-toggle now uses the real `MdRipple` service and therefore the listener is unnecessary.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 20, 2017
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Apr 20, 2017
@kara kara merged commit e82d0f1 into angular:master Apr 21, 2017
@devversion devversion deleted the fix/slide-toggle-mousedown branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants