Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): fix change detection error on autosize #4180

Merged
merged 1 commit into from
Apr 20, 2017

Conversation

kara
Copy link
Contributor

@kara kara commented Apr 20, 2017

Fixes bug where change detection error occurs on autosize (test failure in Google).

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 20, 2017
@kara kara requested a review from jelbourn April 20, 2017 17:34
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit

return this.minRows ? `${this.minRows * this._cachedLineHeight}px` : null;
/** Sets the minimum height of the textarea as determined by minRows. */
_setMinHeight(): void {
const minHeight = this.minRows && this._cachedLineHeight
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer putting the ? at the end of the previous line rather than the start of the new line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@kara kara added the action: merge The PR is ready for merge by the caretaker label Apr 20, 2017
@kara kara merged commit bccf8d2 into angular:master Apr 20, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants