feat(list): option to disable ripples for all items #4159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Apr 20, 2017
src/lib/list/list.ts
Outdated
| private _disableRipple: boolean = false; | ||
| private _isNavList: boolean = false; | ||
|
|
||
| // Variable needs to be public for AOT compilation. |
There was a problem hiding this comment.
We can omit this comment; at this point it's library-wide and we have a CI check for it.
src/lib/list/list.ts
Outdated
| private _lineSetter: MdLineSetter; | ||
| /** | ||
| * Whether the ripple effect on click should be disabled. This applies only to list items that are | ||
| * part of a nav list. The value of `disableRipple` on the `md-nav-list` overwrites this flag. |
There was a problem hiding this comment.
overwrite -> override (since the parent doesn't write a different value, it just takes precedence)
* Allows developers to apply the `[disableRipple]` binding onto the `md-nav-list` element. * Removes the Provider/token stuff, since we can do more elegant by just injecting the NavList styler. Fixes angular#4149.
devversion
force-pushed
the
feat/list-ripple-disable
branch
from
a6b3caa
to
f5bfa10
Compare
jelbourn
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[disableRipple]binding onto themd-nav-listelement.injecting the NavList styler.
disableRipplebinding.Fixes #4149.