Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New @Input in progress-spinner component for controlling the stroke-width #3934

Closed
bfwg opened this issue Apr 6, 2017 · 1 comment · Fixed by #4113
Closed

New @Input in progress-spinner component for controlling the stroke-width #3934

bfwg opened this issue Apr 6, 2017 · 1 comment · Fixed by #4113
Assignees
@devversion
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@bfwg
Copy link

bfwg commented Apr 6, 2017

Bug, feature request, or proposal:

feature request/proposal

What is the expected behavior?

Add an @input to the progress-spinner component so that we can do something like this:
<md-spinner strokeWidth="2"></md-spinner>

What is the current behavior?

I'm not able to find a easy way to control the stroke width for progress spinner.

What is the use-case or motivation for changing an existing behavior?

As a developer, I want to be able to control the thickness for my progress-spinners.
@bfwg bfwg changed the title @Input for controlling the stroke-width for progress-spinner New @Input in progress-spinner component for controlling the stroke-width Apr 6, 2017
@jelbourn jelbourn added feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Apr 9, 2017
@crisbeto crisbeto self-assigned this Apr 10, 2017
devversion added a commit to devversion/material2 that referenced this issue Apr 15, 2017
@devversion
feat(progress-spinner): add support for custom stroke-width
8944ad3 
* Adds support for custom `stroke-width` of the progress-spinner elements.

Fixes angular#3934
@devversion devversion mentioned this issue Apr 15, 2017
Merged
devversion added a commit to devversion/material2 that referenced this issue Apr 16, 2017
@devversion
feat(progress-spinner): add support for custom stroke-width
af36ecb 
* Adds support for custom `stroke-width` of the progress-spinner elements.

Fixes angular#3934
devversion added a commit to devversion/material2 that referenced this issue Apr 16, 2017
@devversion
feat(progress-spinner): add support for custom stroke-width
c9a9e06 
* Adds support for custom `stroke-width` of the progress-spinner elements.

Fixes angular#3934
@crisbeto crisbeto assigned devversion and unassigned crisbeto Apr 17, 2017
devversion added a commit to devversion/material2 that referenced this issue Apr 20, 2017
@devversion
feat(progress-spinner): add support for custom stroke-width
608babe 
* Adds support for custom `stroke-width` of the progress-spinner elements.

Fixes angular#3934
kara pushed a commit that referenced this issue Apr 21, 2017
@devversion @kara
feat(progress-spinner): add support for custom stroke-width (#4113)
b846a27 
Fixes #3934
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(progress-spinner): add support for custom stroke-width devversion/material2
4 participants
@jelbourn @crisbeto @devversion @bfwg