Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Directionality injectable #3600

Closed
EladBezalel opened this issue Mar 14, 2017 · 1 comment · Fixed by #4044
Closed

Introduce Directionality injectable #3600

EladBezalel opened this issue Mar 14, 2017 · 1 comment · Fixed by #4044
Assignees
@EladBezalel
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@EladBezalel
Copy link
Member

Unlike suggested on #1719 to traverse up the DOM and look for any dir attributes
@jelbourn and I decided to only support html and body tags or the Dir directive to get the actual direction.
This was referenced Mar 14, 2017
Closed
Closed
@mmalerba mmalerba added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Mar 14, 2017
@EladBezalel EladBezalel changed the title Introduce LAYOUT_DIRECTION injectable Introduce Directionality injectable Apr 11, 2017
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 11, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
b6215fe 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
@EladBezalel EladBezalel mentioned this issue Apr 11, 2017
Merged
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 15, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
e13c120 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 15, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
909b71e 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 15, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
7d63ed9 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 15, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
8aa1cc9 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 15, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
4b4f560 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 15, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
1793720 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 15, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
5e6040d 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 18, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
a2ced02 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 18, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
fd93d53 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 18, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
0b55dda 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 18, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
11603f0 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 18, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
7eff22e 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 18, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
cda2cc9 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Apr 19, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
ba756f5 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 2, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
7510dc3 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 3, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
6c4822f 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 3, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
9ea4210 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 3, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
1b22426 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 3, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
d4f0d53 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 6, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
742f79f 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 6, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
d712b9d 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 13, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
ce40d79 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
EladBezalel added a commit to EladBezalel/material2 that referenced this issue Jun 13, 2017
@EladBezalel
feat(directionality): a provider to get the overall directionality
ac874fe 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
jelbourn pushed a commit to EladBezalel/material2 that referenced this issue Jun 18, 2017
@EladBezalel @jelbourn
feat(directionality): a provider to get the overall directionality
780b976 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
jelbourn pushed a commit to EladBezalel/material2 that referenced this issue Jun 18, 2017
@EladBezalel @jelbourn
feat(directionality): a provider to get the overall directionality
5f8c663 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes angular#3600
jelbourn pushed a commit that referenced this issue Jun 19, 2017
@EladBezalel @jelbourn
feat(directionality): a provider to get directionality (#4044)
61d979e 
- Looks at the `html` and `body` elements for `dir` attribute and sets the Directionality service value to it
- Whenever someone would try to inject Directionality - if there's a Dir directive up the dom tree it would be provided

fixes #3600
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EladBezalel EladBezalel

Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(directionality): a provider to get the overall directionality EladBezalel/material2
2 participants
@EladBezalel @mmalerba