Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ripples on large elements are too slow and overlap until element turns black #3109

Closed
andrewseguin opened this issue Feb 15, 2017 · 3 comments · Fixed by #3136
Closed

Ripples on large elements are too slow and overlap until element turns black #3109

andrewseguin opened this issue Feb 15, 2017 · 3 comments · Fixed by #3136
Assignees
@devversion
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@andrewseguin
Copy link
Contributor

andrewseguin commented Feb 15, 2017 •
edited
Loading

Bug, feature request, or proposal:

Ripple looks AMAZING on small elements such as buttons. But when applied to a larger element, the ripple crawls along the element. Additionally, if clicked many times, the ripples overlap so much that the element turns black.

What is the expected behavior?

Ripples have the same perceived speed regardless of the element size. When clicked multiple times, the oldest ripples fade out quicker so they don't overlap.

What is the current behavior?

Ripples are slow on large elements and overlap a lot.

What are the steps to reproduce?

See this example for different ripple use cases: http://plnkr.co/edit/Xk6hkgGyGIaaKTnZb493?p=preview

What is the use-case or motivation for changing an existing behavior?

Match closer to spec

Which versions of Angular, Material, OS, browsers are affected?

Master
@andrewseguin andrewseguin added the P2 The issue is important to a large percentage of users, with a workaround label Feb 15, 2017
@andrewseguin
Copy link
Contributor Author

To compare to Material 1, here's a codepen containin a single large button: http://codepen.io/anon/pen/XpGydW

@devversion
Copy link
Member

Cool thanks for the issue. I will look into it!

devversion added a commit to devversion/material2 that referenced this issue Feb 16, 2017
@devversion
fix(ripple): different durations for ripple elements
78744f8 
* No longer uses a `PX_PER_SECOND` variable to calculate the fade-in duration of a ripple element.
* Now ripple elements always have the same `transitionDuration`, which ensures that ripples are faster on bigger elements and slower on smaller elements.

Fixes angular#3109
@devversion devversion mentioned this issue Feb 16, 2017
Merged
andrewseguin pushed a commit that referenced this issue Feb 17, 2017
@devversion @andrewseguin
fix(ripple): different durations for ripple elements (#3136)
5c7a96b 
* No longer uses a `PX_PER_SECOND` variable to calculate the fade-in duration of a ripple element.
* Now ripple elements always have the same `transitionDuration`, which ensures that ripples are faster on bigger elements and slower on smaller elements.

Fixes #3109
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ripple): different durations for ripple elements devversion/material2
2 participants
@devversion @andrewseguin