Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing Dialog using escape only works after initial open w/ button focused #3009

Closed
rosslavery opened this issue Feb 9, 2017 · 1 comment · Fixed by #3082
Closed

Closing Dialog using escape only works after initial open w/ button focused #3009

rosslavery opened this issue Feb 9, 2017 · 1 comment · Fixed by #3082
Assignees
Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@rosslavery
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Dialog should close when escape is pressed, regardless of what is in focus.

What is the current behavior?

If the user interacts with the dialog in any way (causing the initial focus to be lost), pressing escape no longer closes the dialog.

What are the steps to reproduce?

Providing a Plunker (or similar) is the best way to get the team to see your issue.
See: https://material.angular.io/components/component/dialog

What is the use-case or motivation for changing an existing behavior?

A user should be able to press escape to close the dialog at any time.

Which versions of Angular, Material, OS, browsers are affected?

Seemingly all

Is there anything else we should know?

No

@crisbeto crisbeto self-assigned this Feb 9, 2017
@kara kara added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent Accessibility This issue is related to accessibility (a11y) labels Feb 10, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Feb 13, 2017
Fixes issue in the dialog that prevented the user from being able to close via the escape key, if any of the elements inside the dialog loses focus.

Fixes angular#3009.
andrewseguin pushed a commit that referenced this issue Feb 15, 2017
Fixes issue in the dialog that prevented the user from being able to close via the escape key, if any of the elements inside the dialog loses focus.

Fixes #3009.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants