fix(select): selected option not being highlighted when options are added asynchronously #2499
Conversation
googlebot
added
the
cla: yes
| @@ -1235,6 +1255,33 @@ class NgIfSelect { | |||
| } | |||
|
|
|||
|
|
|||
| @Component({ | |||
| selector: 'ng-if-select', | |||
There was a problem hiding this comment.
Copy paste error? Looks like the selector is the same as the component above.
| </md-select> | ||
| ` | ||
| }) | ||
| class SelectWithoutOptions { |
There was a problem hiding this comment.
Nit: This name is a bit misleading, since it does have options. How about SelectInitWithoutOptions or something?
| if (this._control) { | ||
| // Defer setting the value in order to avoid the "Expression has changed after | ||
| // it was checked" errors from Angular. | ||
| Promise.resolve(null).then(() => this.writeValue(this._control.value)); |
There was a problem hiding this comment.
I think what you're looking for is this._setSelectionByValue(this._control.value). writeValue should only really be used by the forms API.
|
Thanks for the feedback @kara, it's addressed. |
|
@crisbeto Can you rebase? When you're done, apply the merge label so we know it's ready :) |
…dded asynchronously Fixes the select component not highlighting the model value when the options get added after initialization. Fixes angular#2497.
crisbeto
force-pushed
the
2497/select-deferred-options
branch
from
7506973
to
5c5351f
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the select component not highlighting the model value when the options get added after initialization.
Fixes #2497.