-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toolbar): prevent content overflow and line-wrapping #2454
Conversation
* No longer wraps lines inside of a `md-toolbar-row` * Overflow for X-axis and Y-Axis are now hidden. Developers should use multiple `md-toolbar-row` elements or can always overwrite the styles. Fixes angular#2451
|
||
// Ensure toolbar content doesn't wrap and exceed the md-toolbar-row width. Ellipsis doesn't work on flex elements. | ||
white-space: nowrap; | ||
overflow: hidden; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a md-truncate-line
mixin for these cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but this also tries to show an ellipsis, which doesn't work and is then unnecessary.
LGTM |
I'm seeing some test failures when I try to merge this into Google's codebase:
|
As discussed with @mmalerba. We are just doing |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
md-toolbar-row
md-toolbar-row
elements or can always overwrite the styles.Note: An ellipsis for flex elements is definitely possible, but it just bloats the toolbar and needs some refactoring. We should revisit this with #1718
Fixes #2451