Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MdSelect does not handle long text well #2440

Closed
jermowery opened this issue Dec 28, 2016 · 2 comments · Fixed by #2444
Closed

MdSelect does not handle long text well #2440

jermowery opened this issue Dec 28, 2016 · 2 comments · Fixed by #2444

Comments

@jermowery
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the expected behavior?

For long text to be truncated with ellipsis (at least that is what the styles seem to suggest).

What is the current behavior?

When the select is open the long text is clipped at the end instead of being displayed with an ellipsis.
When long text is selected the the text goes beyond the select (with the down arrow on top of the text) forever.

What are the steps to reproduce?

See the select: http://plnkr.co/edit/Tg3diW0HhFsDq29rWo4Y?p=preview

What is the use-case or motivation for changing an existing behavior?

Good behavior

Which versions of Angular, Material, OS, browsers are affected?

Latest, Latest, Ubuntu/ChromeOS, Chrome
crisbeto added a commit to crisbeto/material2 that referenced this issue Dec 28, 2016
@crisbeto
fix(select): not trimming long labels
e367278 
* Fixes long text not being trimmed inside of `md-option`, because the element is a flex container. Switches it to `display: block` and uses `line-height` to center the text.
* Fixes the selected value not being trimmed, because the element doesn't have a defined width.

Fixes angular#2440.
@crisbeto crisbeto mentioned this issue Dec 28, 2016
Merged
@jermowery
Copy link
Contributor Author

Thanks for the quick PR!

crisbeto added a commit to crisbeto/material2 that referenced this issue Jan 19, 2017
@crisbeto
fix(select): not trimming long labels
2363f18 
* Fixes long text not being trimmed inside of `md-option`, because the element is a flex container. Switches it to `display: block` and uses `line-height` to center the text.
* Fixes the selected value not being trimmed, because the element doesn't have a defined width.

Fixes angular#2440.
mmalerba pushed a commit that referenced this issue Jan 20, 2017
@crisbeto @mmalerba
fix(select): trim long labels inside md-option (#2444)
416f56f 
* fix(select): not trimming long labels

* Fixes long text not being trimmed inside of `md-option`, because the element is a flex container. Switches it to `display: block` and uses `line-height` to center the text.
* Fixes the selected value not being trimmed, because the element doesn't have a defined width.

Fixes #2440.

* fix: menu icon alignment
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(select): not trimming long labels crisbeto/material2
2 participants
@crisbeto @jermowery