perf(tabs): reduce amount of reflows when aligning the ink bar #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@andrewseguin I think I covered all the bases in regards to the ink bar always being aligned, but it would be nice to have a second pair of eyes on it. |
Currently the ink bar gets aligned to the active tab every time change detection runs. These changes switch to aligning it if the selected index has changed or the header's content has changed. This can be improved further if we were to debounce the MutationObserver changes (will add in a follow-up PR).
crisbeto
force-pushed
the
tab-header-ink-bar-perf
branch
from
6bb4f4e
to
e801679
Compare
|
LGTM |
jelbourn
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 25, 2016
* Adds a reusable utility for debouncing a function. * Adds the ability to debounce the changes from the `cdkObserveContent` directive. * Makes the `cdkObserveContent` directive pass back the `MutationRecord` to the `EventEmitter`. * Fires the callback once per mutation event, instead of once per `MutationRecord`. Relates to angular#2372.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 25, 2016
* Adds a reusable utility for debouncing a function. * Adds the ability to debounce the changes from the `cdkObserveContent` directive. * Makes the `cdkObserveContent` directive pass back the `MutationRecord` to the `EventEmitter`. * Fires the callback once per mutation event, instead of once per `MutationRecord`. Relates to angular#2372.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Mar 28, 2017
* Adds a reusable utility for debouncing a function. * Adds the ability to debounce the changes from the `cdkObserveContent` directive. * Makes the `cdkObserveContent` directive pass back the `MutationRecord` to the `EventEmitter`. * Fires the callback once per mutation event, instead of once per `MutationRecord`. Relates to angular#2372.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 12, 2017
* Adds a reusable utility for debouncing a function. * Adds the ability to debounce the changes from the `cdkObserveContent` directive. * Makes the `cdkObserveContent` directive pass back the `MutationRecord` to the `EventEmitter`. * Fires the callback once per mutation event, instead of once per `MutationRecord`. Relates to angular#2372.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
May 2, 2017
* Adds a reusable utility for debouncing a function. * Adds the ability to debounce the changes from the `cdkObserveContent` directive. * Makes the `cdkObserveContent` directive pass back the `MutationRecord` to the `EventEmitter`. * Fires the callback once per mutation event, instead of once per `MutationRecord`. Relates to angular#2372.
andrewseguin
pushed a commit
that referenced
this pull request
May 2, 2017
) * feat(observe-content): add debounce option and other improvements * Adds a reusable utility for debouncing a function. * Adds the ability to debounce the changes from the `cdkObserveContent` directive. * Makes the `cdkObserveContent` directive pass back the `MutationRecord` to the `EventEmitter`. * Fires the callback once per mutation event, instead of once per `MutationRecord`. Relates to #2372. * Remove flaky tests. * Stub out the MutationObserver. * refactor: use debounce logic from rxjs * chore: fix lint error * fix: refactor the MutationObserver token to not break AoT
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the ink bar gets aligned to the active tab every time change detection runs. These changes switch to aligning it if the selected index has changed or the header's content has changed. This can be improved further if we were to debounce the MutationObserver changes (will add in a follow-up PR).