feat(slider): emit input event when slider thumb moves #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
commented
Dec 21, 2016
| @@ -295,6 +296,7 @@ export class MdSlider implements ControlValueAccessor { | |||
| } | |||
|
|
|||
| @Output() change = new EventEmitter<MdSliderChange>(); | |||
| @Output() input = new EventEmitter<MdSliderChange>(); | |||
There was a problem hiding this comment.
FYI: The JSDoc is intentionally missing here, because otherwise it might collide with #2321
* Adds an input event output, which fires each time the thumb changes its position. Made similar to the native range element `input` event dispatching. Closes angular#2296
devversion
force-pushed
the
feat/slider-input-event
branch
from
0b60b6f
to
4e4a258
Compare
mmalerba
approved these changes
Jan 5, 2017
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made similar to the native range element
inputevent dispatching.Closes #2296