Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): make invalid selector more specific #2166

Merged
merged 1 commit into from
Dec 13, 2016
Merged

Conversation

kara
Copy link
Contributor

@kara kara commented Dec 11, 2016

The selector for the touched/invalid style was too general, so it was picking up when the parent form was "touched" rather than the control itself. This PR ensures it only applies touched/invalid styles when its own control is touched/invalid.

Fixes #2147.

r: @jelbourn

@kara kara requested a review from jelbourn December 11, 2016 10:02
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2016
@dreweird
Copy link

It still the same....all the md-select will turn red even without touching the selector

@kara
Copy link
Contributor Author

kara commented Dec 12, 2016

@dreweird This change isn't merged into master.

@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 12, 2016
@kara kara mentioned this pull request Dec 13, 2016
@jelbourn jelbourn merged commit a7c88c5 into angular:master Dec 13, 2016
@FilipeQ
Copy link

FilipeQ commented Dec 17, 2016

Anyone know when it will be released?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-select applying error styles before it is touched.
5 participants