Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): prevent list item wrapper elements from collapsing #2075

Merged
merged 1 commit into from
Dec 7, 2016

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 4, 2016

Adds a display: block to the list items, in order to prevent them from collapsing. This allows users to set a custom background directly on the list item.

Fixes #2012.

Adds a `display: block` to the list items, in order to prevent them from collapsing. This allows users to set a custom background directly on the list item.

Fixes angular#2012.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 4, 2016
@jelbourn
Copy link
Member

jelbourn commented Dec 6, 2016

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 6, 2016
@mmalerba mmalerba merged commit 27f9c99 into angular:master Dec 7, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set styles on md-list-item
4 participants