Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlabeled checkboxes shouldn't have prescribed padding/margin #2011

Closed
andrewseguin opened this issue Nov 28, 2016 · 1 comment · Fixed by #2121
Closed

Unlabeled checkboxes shouldn't have prescribed padding/margin #2011

andrewseguin opened this issue Nov 28, 2016 · 1 comment · Fixed by #2121
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@andrewseguin
Copy link
Contributor

Checkboxes without labels have a right margin of 8px due to the rule set in .md-checkbox-inner-container. There should be no prescribed margin on the checkbox in this case as it is likely being used apart from a direct text label.
@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 30, 2016
belev added a commit to belev/material2 that referenced this issue Dec 8, 2016
@belev
fix(checkbox): no side margin if label has no content
276a705 
	* Remove side margin in checkbox if label has no content.
	* Use `checkboxNativeElement` instead of `checkboxDebugElement.nativeElement` in expect statements.
	* Fix typo.

Closes angular#2011
belev added a commit to belev/material2 that referenced this issue Dec 8, 2016
@belev
fix(checkbox): no side margin if label has no content
5a6f1f2 
* Remove side margin in checkbox if label has no content.
* Use `checkboxNativeElement` instead of `checkboxDebugElement.nativeElement` in expect statements.
* Fix typo.

Closes angular#2011
@belev belev mentioned this issue Dec 8, 2016
Merged
belev added a commit to belev/material2 that referenced this issue Dec 8, 2016
@belev
fix(checkbox): no side margin if label has no content
7fd1e12 
* Remove side margin in checkbox if label has no content.
* Use `checkboxNativeElement` instead of `checkboxDebugElement.nativeElement` in expect statements.
* Fix typo.

Closes angular#2011
belev added a commit to belev/material2 that referenced this issue Apr 25, 2017
@belev
fix(checkbox): no side margin if label has no content
744505f 
* Remove side margin in checkbox if label has no content.
* Use `checkboxNativeElement` instead of `checkboxDebugElement.nativeElement` in expect statements.
* Fix typo.

Closes angular#2011
mmalerba pushed a commit that referenced this issue Apr 28, 2017
@belev @mmalerba
fix(checkbox): no side margin if label has no content (#2121)
4e8d806 
* Remove side margin in checkbox if label has no content.
* Use `checkboxNativeElement` instead of `checkboxDebugElement.nativeElement` in expect statements.
* Fix typo.

Closes #2011
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(checkbox): no side margin if label has no content belev/material2
3 participants
@jelbourn @tinayuangao @andrewseguin