Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): show tooltip on longpress; remove delay on mouseleave #1819

Merged
merged 3 commits into from
Nov 16, 2016

Conversation

andrewseguin
Copy link
Contributor

Support longpress for mobile users to see tooltips. Adheres better to the md spec which says that "On lift" there should be a delay, which was incorrectly applied to mouseover.

Partially addresses #1808 by hiding the tooltip immediately when the mouse is hidden.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2016
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 11, 2016
@KostyaTretyak
Copy link

KostyaTretyak commented Nov 14, 2016

Also probably need to change the positioning tooltip. Now, when the tooltip is displayed and when the scroll page, tooltip remains fixed.

@kara kara merged commit 1552d70 into angular:master Nov 16, 2016
@fxck
Copy link
Contributor

fxck commented Nov 17, 2016

@KostyaTretyak it's an overlay related problem, very annoying one though, happens to all components using overlay, like menu.

@andrewseguin andrewseguin deleted the tooltip-longpress branch December 20, 2016 22:57
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants