Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progress-circle): allow value to be set to 0 #1536

Merged
merged 1 commit into from
Oct 19, 2016
Merged

fix(progress-circle): allow value to be set to 0 #1536

merged 1 commit into from
Oct 19, 2016

Conversation

andrewseguin
Copy link
Contributor

Value should be considered invalid when null, not just a falsey value. Otherwise 0 is considered an invalid value.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 19, 2016
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit 25c7fd5 into angular:master Oct 19, 2016
@andrewseguin andrewseguin deleted the progress-circle-0 branch October 27, 2016 22:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jelbourn jelbourn

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewseguin @jelbourn @googlebot