Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatability with drag&drop API #1458

Merged
merged 1 commit into from
Oct 19, 2016
Merged

Compatability with drag&drop API #1458

merged 1 commit into from
Oct 19, 2016

Conversation

taffeldt
Copy link
Contributor

@taffeldt taffeldt commented Oct 9, 2016

Remove dragstart and dragend from Hammer.js config so they don't override native HTML5 drag&drop API.
drag event unused right now except for one demo. dragstart and dragend not used at all, should be removed. Eventually, their features can be accessed via drag event anyway.
This should fix issue #1457

Remove dragstart and dragend from Hammer.js config so they don't override native HTML5 drag&drop API.
drag event unused right now except for one demo. dragstart and dragend not used at all, should be removed. Eventually, their features can be accessed via drag event anyway.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 9, 2016
@jelbourn
Copy link
Member

LGTM

@jelbourn jelbourn merged commit b09465c into angular:master Oct 19, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants