Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sidenav): fix Promise type to match #1188

Merged
merged 1 commit into from
Sep 7, 2016
Merged

fix(sidenav): fix Promise type to match #1188

merged 1 commit into from
Sep 7, 2016

Conversation

kara
Copy link
Contributor

@kara kara commented Sep 7, 2016

This PR fixes TS error that Promise<{}> can't be assigned toPromise<void>.

r: @hansl

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 7, 2016
@hansl
Copy link
Contributor

hansl commented Sep 7, 2016

LGTM.

@hansl hansl added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 7, 2016
@kara kara merged commit 3d5ceab into angular:master Sep 7, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@hansl hansl

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kara @hansl @googlebot