feat(dialog): add backdrop #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Closed
jelbourn
force-pushed
the
dialog-backdrop4
branch
from
f652ee6
to
7924997
Compare
jelbourn
force-pushed
the
dialog-backdrop4
branch
from
7924997
to
c12b9cd
Compare
Closed
| this._backdropElement.classList.add('md-overlay-backdrop'); | ||
| this._pane.parentElement.appendChild(this._backdropElement); | ||
|
|
||
| // Forward backdrop clicks that that the consumer of the overlay can perform whatever |
|
LGTM, just a few typos and questions about Sass. |
|
LGTM as well except the few points above. |
| // Forward backdrop clicks that that the consumer of the overlay can perform whatever | ||
| // action desired when such a click occurs (usually closing the overlay). | ||
| this._backdropElement.addEventListener('click', () => { | ||
| this._backdropClick.next(null); |
There was a problem hiding this comment.
Is it intentionally to not pass the DOM event to the Subject? It is not necessary but would be a good improvement though.
There was a problem hiding this comment.
I want to keep any DOM stuff out of public-facing APIs for now (keeping potential running on web-workers in mind).
|
Addressed comments (added todo for fullscreen, since I'm not sure it will stick around forever). |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @kara @hansl
This adds support to the Overlay to add a backdrop. Components that consume the overlay can take the clicks on the backdrop and do whatever they want with them.
This also cleans up the dialog tests; they no longer need a
setTimeoutwith the recent changes tofakeAsyncin core.