Skip to content

Commit

Permalink
fix(button): hover styles being applied to disabled buttons (#909)
Browse files Browse the repository at this point in the history
Fixes the button hover styles being applied, even if a button is disabled.

Fixes #866.
  • Loading branch information
crisbeto authored and jelbourn committed Aug 13, 2016
1 parent 8828358 commit 21e419d
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions src/components/button/button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,17 @@
@import 'button-base';

// TODO(kara): Replace attribute selectors with class selectors when possible
[md-button] {
[md-button], [md-icon-button] {
@extend %md-button-base;

// Only flat buttons and icon buttons (not raised or fabs) have a hover style.
&:hover {
// Use the same visual treatment for hover as for focus.
@include md-button-focus();
}

&[disabled]:hover {
&.md-primary, &.md-accent, &.md-warn, &:hover {
&.md-primary, &.md-accent, &.md-warn, &::after {
background-color: transparent;
}
}
Expand Down Expand Up @@ -60,12 +66,6 @@
z-index: 1;
}

// Only flat buttons and icon buttons (not raised or fabs) have a hover style.
[md-button]:hover, [md-icon-button]:hover {
// Use the same visual treatment for hover as for focus.
@include md-button-focus();
}

// Applies a clearer border for high-contrast mode (a11y)
@media screen and (-ms-high-contrast: active) {
.md-raised-button, .md-fab, .md-mini-fab {
Expand Down

0 comments on commit 21e419d

Please sign in to comment.