This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(util): restore scrolling after test executed. #8206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The current test, was not restoring the scroll mask, which means, that we're not able to remove the scrollbars on the karma site. This broke some positioning tests for `feat/panel`.
|
LGTM |
ThomasBurleson
added
pr: merge ready
jelbourn
pushed a commit
that referenced
this pull request
Apr 28, 2016
* The current test, was not restoring the scroll mask, which means, that we're not able to remove the scrollbars on the karma site. This broke some positioning tests for `feat/panel`. Closes #8206
ThomasBurleson
pushed a commit
that referenced
this pull request
May 17, 2016
* The current test, was not restoring the scroll mask, which means, that we're not able to remove the scrollbars on the karma site. This broke some positioning tests for `feat/panel`. Closes #8206
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke some positioning tests for
feat/panel.cc. @ErinCoughlan