feat(colors): directive to use any color from any palette everywhere #7791

EladBezalel · 2016-03-29T22:24:03Z

added directive and documentation
added tests
added smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watching it

crisbeto · 2016-03-30T09:54:16Z

src/components/colors/colors.js

+    restrict: 'A',
+    link: function (scope, elem, attrs) {
+      scope.$watch(attrs.mdColors, function (val) {
+        Object.keys(val).forEach(function (key) {


You could spare calling Object.keys and iterating it by using angular.forEach(val, function(value, key){ ... });

ErinCoughlan · 2016-03-31T17:05:18Z

@gmoothart Is anything missing here that we could have used for tabs?

googlebot · 2016-03-31T20:50:00Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-03-31T20:50:00Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-04-03T21:59:45Z

CLAs look good, thanks!

googlebot · 2016-04-03T21:59:45Z

CLAs look good, thanks!

ThomasBurleson · 2016-04-03T22:59:57Z

@EladBezalel - The demo needs some text to describe the demo, the intent, and the power of mdColors.
Please explain why this is needed in addition to- Themes.

ThomasBurleson · 2016-04-03T23:01:56Z

In a right-aligned column (in the color boxe), please show the hex color values. e.g. #2196F3.

ThomasBurleson · 2016-04-04T04:44:23Z

Please refactor the colors.spec.js to reduce the non-DRY code.

topherfangio · 2016-04-04T19:47:23Z

@EladBezalel If we introduce this API, I can see developers wanting to use it in many places/components. Can you test the following components to make sure that it is compatible:

Toast (particularly, can you easily change the background color)
Icon
Divider
Subheader
and Tooltip

If it doesn't work out of the box, we may need to update some of the components to make this easier.

ThomasBurleson · 2016-04-04T21:46:21Z

@EladBezalel - see refactored colors.spec.js

EladBezalel · 2016-04-05T15:57:22Z

toast and tooltip have elements containing the styles

… on any element - directive and documentation - service and documentation - tests - smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it - mdColorsWatch - when set to false the directive doesn't watch for changes - $mdColorUtil - aggregate color related utils - fixed theming scoping issue - THEME was defined globally which made it leak and changed for other modules fixes #1269 Closes #7791

googlebot · 2016-04-12T01:12:39Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

googlebot · 2016-04-12T01:12:39Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

EladBezalel · 2016-04-12T07:13:23Z

src/core/services/theming/theming.js


+// Text Colors on light and dakr backgrounds


googlebot · 2016-04-12T17:38:39Z

CLAs look good, thanks!

googlebot · 2016-04-12T17:38:39Z

CLAs look good, thanks!

… on any element - directive and documentation - service and documentation - tests - smart watch option, when the directive recognize at least one of it's values needs interpolation it starts to watch it - mdColorsWatch - when set to false the directive doesn't watch for changes - when using `background` property the directive will seamlessly set the foreground color according the palette hue - $mdColorUtil - aggregate color related utils - fixed theming scoping issue - THEME was defined globally which made it leak and changed for other modules fixes #1269

EladBezalel added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Mar 29, 2016

EladBezalel force-pushed the feat/md-colors branch from 4b3274a to c9ea280 Compare March 29, 2016 23:31

crisbeto reviewed Mar 30, 2016
View reviewed changes

EladBezalel force-pushed the feat/md-colors branch 3 times, most recently from 79a2490 to dffb9e7 Compare March 30, 2016 22:59

EladBezalel force-pushed the feat/md-colors branch from 794bae9 to ddeb37a Compare April 3, 2016 21:59

EladBezalel force-pushed the feat/md-colors branch from ddeb37a to a681c7c Compare April 3, 2016 22:01

EladBezalel force-pushed the feat/md-colors branch 2 times, most recently from 5526d74 to 87b6704 Compare April 9, 2016 15:51

ThomasBurleson force-pushed the feat/md-colors branch from 87b6704 to 54e6834 Compare April 12, 2016 01:12

EladBezalel reviewed Apr 12, 2016
View reviewed changes

src/core/services/theming/theming.js

// Text Colors on light and dakr backgrounds

Copy link

Member Author

EladBezalel Apr 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark

EladBezalel force-pushed the feat/md-colors branch from 54e6834 to 7350b5e Compare April 12, 2016 17:38

EladBezalel force-pushed the feat/md-colors branch from 7350b5e to 6aab69a Compare April 12, 2016 17:39

ThomasBurleson closed this in ced4e0c Apr 12, 2016

EladBezalel deleted the feat/md-colors branch April 12, 2016 22:56

gkalpak mentioned this pull request Apr 13, 2016

Create colors.js for $mdColor service #1599

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(colors): directive to use any color from any palette everywhere #7791

feat(colors): directive to use any color from any palette everywhere #7791

EladBezalel commented Mar 29, 2016

crisbeto Mar 30, 2016

ErinCoughlan commented Mar 31, 2016

googlebot commented Mar 31, 2016

googlebot commented Mar 31, 2016

googlebot commented Apr 3, 2016

googlebot commented Apr 3, 2016

ThomasBurleson commented Apr 3, 2016

ThomasBurleson commented Apr 3, 2016

ThomasBurleson commented Apr 4, 2016

topherfangio commented Apr 4, 2016

ThomasBurleson commented Apr 4, 2016

EladBezalel commented Apr 5, 2016

googlebot commented Apr 12, 2016

googlebot commented Apr 12, 2016

EladBezalel Apr 12, 2016

googlebot commented Apr 12, 2016

googlebot commented Apr 12, 2016

feat(colors): directive to use any color from any palette everywhere #7791

feat(colors): directive to use any color from any palette everywhere #7791

Conversation

EladBezalel commented Mar 29, 2016

crisbeto Mar 30, 2016

Choose a reason for hiding this comment

ErinCoughlan commented Mar 31, 2016

googlebot commented Mar 31, 2016

googlebot commented Mar 31, 2016

googlebot commented Apr 3, 2016

googlebot commented Apr 3, 2016

ThomasBurleson commented Apr 3, 2016

ThomasBurleson commented Apr 3, 2016

ThomasBurleson commented Apr 4, 2016

topherfangio commented Apr 4, 2016

ThomasBurleson commented Apr 4, 2016

EladBezalel commented Apr 5, 2016

googlebot commented Apr 12, 2016

googlebot commented Apr 12, 2016

EladBezalel Apr 12, 2016

Choose a reason for hiding this comment

googlebot commented Apr 12, 2016

googlebot commented Apr 12, 2016