This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(progress-circular): add theming, simplify demo #7576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,13 +47,22 @@ angular | |||
| '$$rAF', | |||
| '$window', | |||
| '$mdProgressCircular', | |||
| '$mdTheming', | |||
There was a problem hiding this comment.
Just a question related to the progress circular. Why are we using Strict DI here?
There was a problem hiding this comment.
Good question. I suppose I just went with it out of habit, I'll switch to the regular DI.
* Applies `$mdTheming` to the `progressCircular` component. * Simplifies the `progressCircular` demo and adds an example of the dark theme colors. * Removes strict dependency injection in the `progressCircularDirective`. Closes angular#7570.
crisbeto
force-pushed
the
fix/progress-circular-theming
branch
from
09c5180
to
8850b10
Compare
|
It's updated to include the dark theme and the notes by @devversion, @ThomasBurleson. |
|
@crisbeto Theming and DI looks good to me 👍 |
crisbeto
added
pr: merge ready
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$mdThemingto theprogressCircularcomponent.progressCirculardemo.Closes #7570.