This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat(toast): add highlight class method + improved docs design + align demo with specs #7246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
fix/toast-align-specs
branch
from
10dd6fc
to
3078ab8
Compare
| &.md-accent { | ||
| color: '{{accent-A200}}'; | ||
| // By default the toast should use the accent color as the primary highlight color | ||
| color: '{{accent-A200}}'; |
There was a problem hiding this comment.
@devversion This is a breaking change since we are changing the default from primary to accent. I believe it is a correct breaking change, but we need to make sure that we note it in the commit message (and PR description) so that users will know. Can you update the commit message accordingly?
There was a problem hiding this comment.
Thank's for remembering, just updated :)
…n demo with specs BREAKING CHANGE: Toasts now use accent color by default for a highlighted action button. - Add `highlightClass` method to toast (very useful! - and won't break anything) - Improved the docs design for the possible methods for the #simple method. - Changed demo to align with specs, No Dismiss buttons. - Highlight Color should use by default the accent color. Fixes angular#6607
devversion
force-pushed
the
fix/toast-align-specs
branch
from
3078ab8
to
883591c
Compare
topherfangio
added
needs: review
ThomasBurleson
removed
the
needs: review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Toasts now use accent color by default for a highlighted action button.
highlightClassmethod to toast (very useful! - and won't break anything)@topherfangio As discussed changed the demo and the default highlight color.
highlightClass, we didn't discuss that, but it seems very useful, when aligning the toast to the official specs.Little preview of the new docs changes
Preview of the old doc design
I think the new design looks much more clearer and also looks better with the new
highlightClassmethod.Fixes #6607