This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(autocomplete): fix not found template detection when element is hidden #7042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
force-pushed
the
fix/autocomplete-has-notfound
branch
2 times, most recently
from
d0688d0
to
fcda88c
Compare
This was referenced Feb 8, 2016
|
Rerunning the build to see if we can merge this as the the build failure doesn't appear related to the code changes. |
|
Thanks @topherfangio! Update: - Need to rebase this PR due the PhantomJS2 changes. |
devversion
force-pushed
the
fix/autocomplete-has-notfound
branch
from
fcda88c
to
df7db60
Compare
|
@devversion Did you already do the rebase? It looks like the tests are passing again. If so, I'll make it as needs merge. Thanks! |
|
@topherfangio Yes, already rebased. Thanks for tracking 👍 |
topherfangio
added
pr: merge ready
|
@ThomasBurleson LGTM, should be a simple non-breaking change. |
…idden When the element is hidden at compilation time through a ng-if directive for example. The stored variable as currently used will be trashed, so it will be undefined. So there a possibilities to store that state, using a variable in the directive (ex. hashmaps with ids) or storing it as an attribute / class. Fixes angular#7035 Fixes angular#7142
devversion
force-pushed
the
fix/autocomplete-has-notfound
branch
from
df7db60
to
bd0255c
Compare
|
thanks @devversion. |
|
thanks @devversion fixes it nicely for me |
|
@devversion - 👍 |
ThomasBurleson
pushed a commit
that referenced
this pull request
Feb 26, 2016
…idden When the element is hidden at compilation time through a ng-if directive for example. The stored variable as currently used will be trashed, so it will be undefined. So there a possibilities to store that state, using a variable in the directive (ex. hashmaps with ids) or storing it as an attribute / class. Fixes #7035 Fixes #7142 Closes #7042
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the element is hidden at compilation time through a ng-if or ng-repeat directive for example.
The stored variable as currently used will be trashed, so it will be undefined.
So there a possibilities to store that state, using a variable in the directive (ex. hashmaps with ids) or storing it as an attribute / class.
Fixes #7035 Fixes #7142