Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(input): smart icon support should notice other input tags too #6979

Closed

Conversation

devversion
Copy link
Member

Textarea:

Select:

@EladBezalel Please review.

  • Added no tests for left + right aligned icons because then it will be like a duplicate. Should I add them too?

Fixes #6977

@devversion devversion force-pushed the fix/input-smarticons-othertags branch from e36bb64 to 6153b06 Compare February 2, 2016 14:31
@devversion devversion force-pushed the fix/input-smarticons-othertags branch from 6153b06 to 999384b Compare February 2, 2016 14:36
@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Feb 2, 2016
@ThomasBurleson ThomasBurleson added this to the 1.0.5 milestone Feb 2, 2016
@EladBezalel
Copy link
Member

No need, LGTM

@EladBezalel EladBezalel added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Feb 4, 2016
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
@devversion devversion deleted the fix/input-smarticons-othertags branch April 19, 2016 19:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants