-
Notifications
You must be signed in to change notification settings - Fork 3.4k
<fix(datepicker)>: change mdDateUtil.isDateWithinRange to ignore the … #6888
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
4a64a61
to
295d0a1
Compare
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
@jelbourn - can you review ? |
return (!angular.isDate(minDate) || minDate <= date) && | ||
(!angular.isDate(maxDate) || maxDate >= date); | ||
var dateAtMidnight = createDateAtMidnight(date); | ||
var minDateAtMidnight = angular.isDate(minDate) ? createDateAtMidnight(minDate) : null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of angular.isDate
, use isValidDate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
LGTM aside from one comment. Great contribution, thanks! |
…time component of the date Previously, mdDateUtil.isDateWithinRange did a simple comparison on the given dates. Since this component is used for dates (and not times or datetimes), this leads to inconsistent behavior. Fixes angular#6887
295d0a1
to
082623e
Compare
PTAL |
…me component of the date Previously, mdDateUtil.isDateWithinRange did a simple comparison on the given dates. Since this component is used for dates (and not times or datetimes), this leads to inconsistent behavior. Fixes angular#6887 Closes angular#6888
…time component of the date
Previously, mdDateUtil.isDateWithinRange did a simple comparison on the given dates. Since this
component is used for dates (and not times or datetimes), this leads to inconsistent behavior.
Fixes #6887