This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
feat($mdDialog): add prompt #6769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add preconfigured dialog for prompt. Fixes #4995
| }; | ||
| this.abort = function() { | ||
| $mdDialog.cancel(); | ||
| }; | ||
| this.keypress = function($event) { | ||
| if ($event.keyCode === $mdConstant.KEY_CODE.ENTER) { | ||
| $mdDialog.hide(this.result) |
There was a problem hiding this comment.
Do you not want to call this.hide() instead in order to account for type == 'prompt'?
There was a problem hiding this comment.
ng-keypress is only set if dialog.$type == 'prompt' on line 520, so it won't make a difference, if I understand your question.
|
@zbjornson - see my one (1) question/concern.
|
ThomasBurleson
added
pr: merge ready
|
Thanks for the review! |
ThomasBurleson
removed
the
needs: feedback
ErinCoughlan
pushed a commit
to ErinCoughlan/material
that referenced
this pull request
Feb 9, 2016
Add preconfigured dialog for prompt. Fixes angular#4995. Closes angular#6769.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add preconfigured dialog for prompt. Fixes #4995.
I didn't see the bit about "not actively reviewing unsolicited PRs" until after I did this :(. This is relatively minor, only 20 lines of code; remaining 160 are docs and tests.