Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(datepicker): set datepicker touched if bluring input or closing the pane #6722

Closed
wants to merge 1 commit into from
Closed

fix(datepicker): set datepicker touched if bluring input or closing the pane #6722

wants to merge 1 commit into from

Conversation

devversion
Copy link
Member

Fixes #6598

@kamilkisiela kamilkisiela mentioned this pull request Jan 19, 2016
Open
6 tasks
@ThomasBurleson
Copy link
Contributor

@jelbourn - can you review?

@ThomasBurleson ThomasBurleson added the needs: review This PR is waiting on review from the team label Jan 28, 2016
jelbourn
jelbourn reviewed Jan 28, 2016
View reviewed changes
src/components/datepicker/datePicker.js
@@ -598,6 +600,7 @@
* @param {boolean} isFocused
*/
DatePickerCtrl.prototype.setFocused = function(isFocused) {
if (isFocused === false) this.ngModelCtrl.$setTouched();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-style to

if (!isFocused) {
  this.ngModelCtrl.$setTouched();
}

@jelbourn
Copy link
Member

LGTM aside from one style comment. Thanks for the fix!

@devversion
Copy link
Member Author

@jelbourn Updated :)

@jelbourn jelbourn added pr: merge ready This PR is ready for a caretaker to review and removed needs: review This PR is waiting on review from the team labels Jan 28, 2016
@jelbourn jelbourn closed this in f4839af Jan 28, 2016
@jelbourn jelbourn mentioned this pull request Jan 28, 2016
Closed
ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
@devversion @ErinCoughlan
fix(datepicker): set datepicker touched if bluring input or closing t…
5fc607b 
…he pane

Fixes angular#6598

Closes angular#6722
@devversion devversion deleted the fix/datepicker-model-touched branch April 21, 2016 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jelbourn jelbourn

Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @ThomasBurleson @jelbourn