Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(dialog): fix focus trap sometimes not working #6590

Closed
wants to merge 1 commit into from

Conversation

ErinCoughlan
Copy link
Contributor

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ErinCoughlan
Copy link
Contributor Author

I signed it! as part of the Google Corporation.

@googlebot
Copy link

CLAs look good, thanks!

@jelbourn
Copy link
Member

jelbourn commented Jan 8, 2016

LGTM

Can you squash your commits with git rebase -i and update the commit name to match our pattern? It would be something like
`fix(dialog): fix focus trap sometimes not working"

@jelbourn jelbourn added pr: merge ready This PR is ready for a caretaker to review needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved and removed pr: merge ready This PR is ready for a caretaker to review labels Jan 8, 2016
@ErinCoughlan ErinCoughlan changed the title Bug Fix: Removes bind in dialog focus trap. fix(dialog): fix focus trap sometimes not working Jan 8, 2016
@ErinCoughlan
Copy link
Contributor Author

Fixed commit message and squashed the commits.

@jelbourn jelbourn added pr: merge ready This PR is ready for a caretaker to review and removed needs: rebase This PR needs to be rebased on the latest commits from master and conflicts need to be resolved labels Jan 8, 2016
@ErinCoughlan ErinCoughlan reopened this Jan 8, 2016
@ErinCoughlan ErinCoughlan self-assigned this Jan 8, 2016
@ErinCoughlan ErinCoughlan deleted the fix-dialog branch February 10, 2016 21:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants