Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(toolbar): solves NgUpgrade interop issue. Fixes #6069 #6081

Closed
wants to merge 1 commit into from
Closed

fix(toolbar): solves NgUpgrade interop issue. Fixes #6069 #6081

wants to merge 1 commit into from

Conversation

alex94cp
Copy link
Contributor

@alex94cp alex94cp commented Dec 4, 2015

I know development is currently focused on ng2, but these changes are so minor it can't hurt

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@alex94cp
Copy link
Contributor Author

alex94cp commented Dec 4, 2015

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@alex94cp alex94cp closed this Dec 4, 2015
@alex94cp alex94cp reopened this Dec 4, 2015
@alex94cp alex94cp closed this Dec 4, 2015
@alex94cp alex94cp reopened this Dec 4, 2015
@alex94cp alex94cp changed the title fix(mbToolbar): Fixes NgUpgrade interop issue (#6069) Fixes toolbar NgUpgrade interop issue (#6069) Dec 4, 2015
@alex94cp
Copy link
Contributor Author

alex94cp commented Dec 4, 2015

PR now passes all tests. It depends on angular/angular#5604

@alex94cp alex94cp changed the title Fixes toolbar NgUpgrade interop issue (#6069) fix(toolbar): solves NgUpgrade interop issue. Fixes #6069 Dec 4, 2015
@ThomasBurleson ThomasBurleson added this to the 1.0-rc7 milestone Dec 4, 2015
@ThomasBurleson ThomasBurleson self-assigned this Dec 4, 2015
@ThomasBurleson
Copy link
Contributor

@jelbourn - Seems like something to have before our v1.0.0 release. thoughts ?

@jelbourn
Copy link
Member

jelbourn commented Dec 7, 2015

LGTM, this is fine

@jelbourn jelbourn added the pr: merge ready This PR is ready for a caretaker to review label Dec 7, 2015
@jelbourn jelbourn closed this in c668ba4 Dec 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr: merge ready This PR is ready for a caretaker to review type: build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants