Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

fix(listItem): allow for multiple md-secondary items #5958

Closed
wants to merge 1 commit into from
Closed

fix(listItem): allow for multiple md-secondary items #5958

wants to merge 1 commit into from

Conversation

OzzieOrca
Copy link
Contributor

Addresses #2595
This allows the following code to produce the list items in the picture below:

<md-list-item ng-repeat="person in people" ng-click="goToPerson(person)">
    <img class="md-avatar" ng-src="{{ person.picture }}">
    <p>{{ person.name }}</p>
    <md-checkbox class="md-secondary" ng-model="person.selected"></md-checkbox>
    <ng-md-icon icon="email" ng-click="sendEmail(person)" aria-label="Send Email" class="md-secondary"></ng-md-icon>
    <ng-md-icon icon="message" ng-click="sendText(person)" aria-label="Send Text" class="md-secondary"></ng-md-icon>
</md-list-item>

screen shot 2015-11-27 at 12 35 34 pm

Does this look like a decent solution? There might be a more general way to handle it or a better way. Let me know if you see any issues with it.

])
.controller('MdListController', MdListController)
.directive('mdList', mdListDirective)
.directive('mdListItem', mdListItemDirective);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not a good thing, to reformat this snippet.
See below formating comment

@OzzieOrca
Copy link
Contributor Author

I think I've fixed those formatting issues. I used the auto indenting feature in my IDE and didn't check whitespace before committing. Let me know if you see any more.

@devversion
Copy link
Member

Looks good now!. Thanks for fixing it 👍

@gpopovic
Copy link

This is awesome.. Good work

@ThomasBurleson ThomasBurleson modified the milestone: 1.0-rc8 Dec 2, 2015
@8cells
Copy link

8cells commented Dec 30, 2015

Could someone merge it?

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc8, 1.1.0 Jan 5, 2016
@ThomasBurleson ThomasBurleson added the P4: minor Minor issues. May not be fixed without community contributions. label Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.1.0, Backlog Jan 15, 2016
@asm0dey
Copy link

asm0dey commented Jan 31, 2016

👍
Please, merge!

@ThomasBurleson ThomasBurleson added the pr: merge ready This PR is ready for a caretaker to review label Feb 1, 2016
@ThomasBurleson ThomasBurleson self-assigned this Feb 1, 2016
@ThomasBurleson ThomasBurleson modified the milestones: 1.0.5, Backlog Feb 1, 2016
@justechn
Copy link

justechn commented Feb 6, 2016

@ThomasBurleson I saw that you tagged 1.0.5, but this was not included. Do you have any idea when this will be released?

@timmyrosen
Copy link

Also curious about this

@devversion
Copy link
Member

@justechn @timmyrosen There is a new release process. Read more here

@justechn
Copy link

justechn commented Feb 8, 2016

@devversion I assume you are meaning that this will be in a minor release, not in a patch release? So it will be released sometime in the next month or two?

The only reason I asked is because @ThomasBurleson set the milestone as 1.0.5 7 days ago, but when 1.0.5 was release this was not included. I guess the milestone should have been left at 1.1.0.

ErinCoughlan pushed a commit to ErinCoughlan/material that referenced this pull request Feb 9, 2016
@OzzieOrca OzzieOrca deleted the multiple-secondary-items branch January 15, 2017 22:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants