-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(listItem): allow for multiple md-secondary items #5958
Conversation
]) | ||
.controller('MdListController', MdListController) | ||
.directive('mdList', mdListDirective) | ||
.directive('mdListItem', mdListItemDirective); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not a good thing, to reformat this snippet.
See below formating comment
I think I've fixed those formatting issues. I used the auto indenting feature in my IDE and didn't check whitespace before committing. Let me know if you see any more. |
Looks good now!. Thanks for fixing it 👍 |
This is awesome.. Good work |
Could someone merge it? |
👍 |
@ThomasBurleson I saw that you tagged 1.0.5, but this was not included. Do you have any idea when this will be released? |
Also curious about this |
@justechn @timmyrosen There is a new release process. Read more here |
@devversion I assume you are meaning that this will be in a minor release, not in a patch release? So it will be released sometime in the next month or two? The only reason I asked is because @ThomasBurleson set the milestone as 1.0.5 7 days ago, but when 1.0.5 was release this was not included. I guess the milestone should have been left at 1.1.0. |
Addresses #2595
This allows the following code to produce the list items in the picture below:
Does this look like a decent solution? There might be a more general way to handle it or a better way. Let me know if you see any issues with it.