This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(slider): use validators too if its numeric string #5874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Normally the numeric string will be applied to the model and the slider won't check for min and max. This checks the strings too and validates for min and max Before: http://codepen.io/anon/pen/vNMvNZ After: http://codepen.io/DevVersion/pen/yYrGVW Fixes angular#5872
ThomasBurleson
added
needs: review
|
rel #4371 |
EladBezalel
added a commit
that referenced
this pull request
Feb 27, 2016
- Added vertical slider - Improved UI - Fixed dynamic min/max with values not in range - Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation. - Made input width grow or shrink according the text length - Added discrete readonly mode - Added disabled on slider container fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093 closes #5874, #5872, #6051
EladBezalel
added a commit
that referenced
this pull request
Feb 27, 2016
- Added vertical slider - Improved UI - Fixed dynamic min/max with values not in range - Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation. - Made input width grow or shrink according the text length - Added discrete readonly mode - Added disabled on slider container fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093 closes #5874, #5872, #6051
ThomasBurleson
pushed a commit
that referenced
this pull request
Mar 2, 2016
- Added vertical slider - Improved UI - Fixed dynamic min/max with values not in range - Added round attribute to set how many numbers should be after the dot, default is 3, maximum is 6 to prevent scientific notation. - Made input width grow or shrink according the text length - Added discrete readonly mode - Added disabled on slider container fixes #4371, #3259, #2421, #1221, #4576, #6996, #7093, #7093 closes #5874, #5872, #6051
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the numeric string will be applied to the model and the slider won't check for min and max.
This checks the strings too and validates for min and max
Before: http://codepen.io/anon/pen/vNMvNZ
After: http://codepen.io/DevVersion/pen/yYrGVW
Fixes #5872