Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

hide-gt-sm attribute not working #5166

Closed
verkestk opened this issue Oct 14, 2015 · 4 comments
Closed

hide-gt-sm attribute not working #5166

verkestk opened this issue Oct 14, 2015 · 4 comments
Assignees
Labels
P2: required Issues that must be fixed. ui: flexbox
Milestone

Comments

@verkestk
Copy link

This bug is visible on https://material.angularjs.org/0.11.2/#/layout/options.

As the screen resizes, the sibling element with the "show-sm" attribute appears and disappears as expected. But the "hide-gt-sm" element is always visible.

Tested in safari & chrome.

screen shot 2015-10-14 at 1 52 10 pm

@ThomasBurleson
Copy link
Contributor

Thank you. We are aware of this issue and will continue to improve the Layout features during the next several weeks.

@ThomasBurleson ThomasBurleson self-assigned this Oct 14, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 0.12.0, 0.12, 0.13 Oct 14, 2015
@m19
Copy link

m19 commented Oct 22, 2015

<div layout="column" hide show-gt-md>
</div>

Want to confirm this div is hidden on my Macbook Pro Retina screen with latest Chrome. Upgraded from 0.10.1 to 1.0.0-rc1

@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc2, 1.0-rc3 Oct 30, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc3, 1.0-rc4 Nov 7, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc4, 1.0-rc5 Nov 16, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc5, 1.0-rc8 Nov 25, 2015
@ThomasBurleson ThomasBurleson modified the milestones: 1.0-rc8, 1.1.0 Jan 5, 2016
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 1.1.0 Jan 5, 2016
@chrisguerrero
Copy link
Contributor

@ThomasBurleson

I'm experiencing the same issue after upgrading from v0.11.4 to v1.0.1. I use md-layout-css to disable the Layout JS engine per #5020:

http://codepen.io/chrisguerrero/pen/BjwazQ

When md-layout-css is removed, the class selectors added by the Layout JS engine work as expected. I require the layout selectors in my app because I use the ngMaterial grid system on non-angular pages.

@ThomasBurleson ThomasBurleson added the P2: required Issues that must be fixed. label Jan 15, 2016
@ThomasBurleson ThomasBurleson modified the milestones: Backlog, 1.1.0 Jan 15, 2016
chrisguerrero pushed a commit to chrisguerrero/material that referenced this issue Mar 18, 2016
    layout-attributes.scss small screen breakpoints out of sync with layout.scss

    Closes angular#5166: hide-gt-sm attribute not working
@chrisguerrero
Copy link
Contributor

It appears as though the issue is an incorrect attribute selector in layout-attributes.scss:

https://github.com/angular/material/blob/master/src/core/services/layout/layout-attributes.scss#L434

Compared to the same class definition in layout.scss:

https://github.com/chrisguerrero/material/blob/master/src/core/services/layout/layout.scss#L67

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2: required Issues that must be fixed. ui: flexbox
Projects
None yet
Development

No branches or pull requests

4 participants