Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Material icons should be accessible #427

Closed
marcysutton opened this issue Oct 14, 2014 · 3 comments
Closed

Material icons should be accessible #427

marcysutton opened this issue Oct 14, 2014 · 3 comments
Assignees
Labels
a11y This issue is related to accessibility
Milestone

Comments

@marcysutton
Copy link
Contributor

To be accessible, <md-icon> needs two things:

  1. aria-label should be enforced. (see Improving aria-label warnings #344)
  2. The nested <object> tag needs wmode="opaque" or wmode="transparent" since it is for presentation only (Flash a11y best practices)

I remember something about a refactor possibly forthcoming, I just wanted to capture these requirements.

@marcysutton marcysutton added the a11y This issue is related to accessibility label Oct 14, 2014
@marcysutton
Copy link
Contributor Author

This is still an issue, and it has implications for other components such as <md-button> (which is used with <md-tooltip>. No label is required on <md-icon> itself, leaving the parent element responsible for labeling (and throwing errors). For example:

<md-button class="md-fab md-primary">
  <md-tooltip>
    Refresh
  </md-tooltip>
  <md-icon icon="/img/icons/ic_refresh_24px.svg"></md-icon>
</md-button>

This fails for accessibility because <md-tooltip> does not provide an accessible name for <md-button>. This should be the responsibility of <md-icon>, either by providing aria-label or some other labeling mechanism.

If we enforce aria-label on <md-icon>, we will need to update $mdAria.expect to check for aria-label on child nodes. Opened issue #567.

@ThomasBurleson ThomasBurleson modified the milestones: 0.8.0-rc1, 0.7.0-rc1 Nov 13, 2014
@ThomasBurleson
Copy link
Contributor

Related to #612, #567

@marcysutton marcysutton modified the milestones: 0.8.0-rc1, 0.7.0-rc1 Dec 4, 2014
@marcysutton
Copy link
Contributor Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility
Projects
None yet
Development

No branches or pull requests

2 participants