This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
fix(css): remove styles that could apply to user-controlled elements. #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jelbourn LGTM - might want to include a BREAKING CHANGE warning in the commit message. |
jelbourn
force-pushed
the
broad-border-box
branch
from
612ef6b
to
ea5deaa
Compare
kennethcachia
pushed a commit
to kennethcachia/material
that referenced
this pull request
Sep 23, 2015
BREAKING CHANGE: modify scope of `box-sizing: border-box` to be specific to only to elements owned by ngMaterial.
Before:
```css
*,*:before,*:after {
box-sizing: border-box;
}
.md-container { }
```
After
```css
.md-container {
box-sizing: border-box;
}
```
Refs angular#3516. Closes angular#4222
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
@ThomasBurleson @robertmesserle
Related to #3516
I'm removing style rules that would affect elements that are not created/owned by ng-material. As far as I can tell form looking at the demos after this, everything is still the same on our end. Users that were inadvertently depending on these styles will be affected.