Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

md-tabs programmatic selection of tab not updating pagination #3139

Closed
Stexxen opened this issue Jun 5, 2015 · 5 comments
Closed

md-tabs programmatic selection of tab not updating pagination #3139

Stexxen opened this issue Jun 5, 2015 · 5 comments

Comments

@Stexxen
Copy link
Contributor

Stexxen commented Jun 5, 2015

When selectedIndex is changed programmatically, the tab is correctly selected and the correct tab content is shown.
But if the tabs are currently paginated and the newly selected tab is on a different page to the one currently shown, then the pagination is not updated, so you have no visibility of the selected tab header.

bug_before

@Stexxen
Copy link
Contributor Author

Stexxen commented Jun 5, 2015

Created Pull #3143 to resolve
bug_after

@Stexxen
Copy link
Contributor Author

Stexxen commented Jun 12, 2015

@robertmesserle Could you confirm what version this is fixed in? I've just used bower material commit angular/bower-material@d0bf101 which I believe is 0.10.rc4 and the issue is still present.
You had previously mentioned it was fixed in the comments of my pull request. #3143

@robertmesserle
Copy link
Contributor

Re-opening. This was fixed in a previous version, but seems to be broken again. I am working on a proper fix right now for this as well as some other pagination issues.

@robertmesserle
Copy link
Contributor

@Stexxen This should be resolved now as well as a few other pagination-related issues. (ie. resizing the window and adding tabs will also adjust for this.)

Thanks for the updates! Please confirm once this commit makes its way to bower.

@Stexxen
Copy link
Contributor Author

Stexxen commented Jun 12, 2015

@robertmesserle Confirmed as working in angular/bower-material@1d78f35

Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants