Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Polish Linear Progress Bar #297

Closed
3 tasks done
EisenbergEffect opened this issue Sep 19, 2014 · 2 comments
Closed
3 tasks done

Polish Linear Progress Bar #297

EisenbergEffect opened this issue Sep 19, 2014 · 2 comments
Assignees
Labels
a11y This issue is related to accessibility type: enhancement
Milestone

Comments

@EisenbergEffect
Copy link
Contributor

  • Add Unit Tests
  • Improve Accessibility
  • Improve Animation Performance on Mobile
@EisenbergEffect EisenbergEffect self-assigned this Sep 19, 2014
@EisenbergEffect EisenbergEffect added this to the 0.0.4 milestone Sep 19, 2014
@EisenbergEffect
Copy link
Contributor Author

Notes from @marcysutton

Note added about ARIA on the progress element itself. If it is showing progress of a specific region of the page, we may want to add code that establishes a relationship between the progress indicator and the other region:

"If the progressbar describes the loading progress of a particular region of a page, use aria-describedby to point to the region, and set aria-busy="true" on the region until it is finished loading."

More about the progressbar role: http://www.w3.org/TR/wai-aria/roles#progressbar

@EisenbergEffect
Copy link
Contributor Author

Notes from @ajoslin

I'm almost sure the animation of width and top will be really slow there. width and top changes aren't GPU accelerated.

We need to figure out a way to do this animation using transform, with translate/scale.

@EisenbergEffect EisenbergEffect added a11y This issue is related to accessibility test type: enhancement labels Sep 22, 2014
EisenbergEffect added a commit that referenced this issue Sep 22, 2014
This fix adds support for aria-valuemin, aria-valuemax and
aria-valuenow. The valuemin and valuemax attributes are static and thus
added during the compile phase. The valuenow attribute is updated as
the progress bar’s value attribute changes.

This commit relates to issue #297
EisenbergEffect added a commit that referenced this issue Sep 29, 2014
This set of changes adds expected progress-bar aria attributes. It also
adds a small unit test suite. Finally, the animations have been
converted to transforms in order to engage hardware acceleration,
particularly on mobile devices.

Fixes #297
EisenbergEffect added a commit that referenced this issue Sep 29, 2014
This fix adds support for aria-valuemin, aria-valuemax and
aria-valuenow. The valuemin and valuemax attributes are static and thus
added during the compile phase. The valuenow attribute is updated as
the progress bar’s value attribute changes.

This commit relates to issue #297
EisenbergEffect added a commit that referenced this issue Sep 29, 2014
This set of changes adds expected progress-bar aria attributes. It also
adds a small unit test suite. Finally, the animations have been
converted to transforms in order to engage hardware acceleration,
particularly on mobile devices.

Fixes #297
EisenbergEffect added a commit that referenced this issue Sep 30, 2014
This set of changes adds expected progress-bar aria attributes. It also
adds a small unit test suite. Finally, the animations have been
converted to transforms in order to engage hardware acceleration,
particularly on mobile devices.

Fixes #297
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant