Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

Disabled checkbox should not be in the tab order #2087

Closed
marcysutton opened this issue Mar 30, 2015 · 1 comment
Closed

Disabled checkbox should not be in the tab order #2087

marcysutton opened this issue Mar 30, 2015 · 1 comment
Assignees
@marcysutton
Milestone
0.9.0

Comments

@marcysutton
Copy link
Contributor

To better align with native checkboxes, mdCheckbox components using ng-disabled should not have tabIndex=0. A native checkbox will not be part of the tab order when the disabled attribute is used. The Material Checkbox should have similar behavior.

@ThomasBurleson started PR #1168 for ng-disabled improvements for mdButton, but I wanted to capture the mdCheckbox tabindex issue. mdSwitch does not suffer from the same problem.

See the "mdCheckbox" section in this Codepen: http://codepen.io/marcysutton/pen/yyxREg
Compare it to this native checkbox Codepen: http://codepen.io/marcysutton/pen/GgxboO
@marcysutton marcysutton added this to the 0.10.0 milestone Mar 31, 2015
@marcysutton marcysutton modified the milestones: 0.9.0, 0.10.0 Apr 13, 2015
@marcysutton marcysutton self-assigned this Apr 13, 2015
marcysutton pushed a commit that referenced this issue Apr 13, 2015
fix(checkbox): disable checkboxes with tabindex=-1
d9cb114 
Closes #2087
@marcysutton marcysutton mentioned this issue Apr 13, 2015
Closed
@ajoslin ajoslin added the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 13, 2015
@ThomasBurleson
Copy link
Contributor

Related to #2297

marcysutton pushed a commit that referenced this issue Apr 13, 2015
fix(checkbox): disable checkboxes with tabindex=-1
d3dd87a 
Closes #2087
marcysutton pushed a commit that referenced this issue Apr 13, 2015
fix(checkbox): disable checkboxes with tabindex=-1
973d89f 
Closes #2087
@ajoslin ajoslin removed the in progress Mainly for in progress PRs, but may be used for issues that require multiple PRs label Apr 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@marcysutton marcysutton

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

fix(checkbox): disable checkboxes with tabindex=-1 angular/material
3 participants
@ThomasBurleson @marcysutton @ajoslin