Skip to content
This repository has been archived by the owner on Sep 5, 2024. It is now read-only.

mdTabs: focused tab is now too white #1260

Closed
PaulMougel opened this issue Jan 22, 2015 · 15 comments
Closed

mdTabs: focused tab is now too white #1260

PaulMougel opened this issue Jan 22, 2015 · 15 comments
Assignees
Milestone

Comments

@PaulMougel
Copy link
Contributor

dd5b954 broke the color of the focused tab, see for instance the demo page:

image

cc @rschmukler

@aseemgautam
Copy link

There's also a flicker on Firefox (35) and IE 11 when selecting a tab.

@PaulMougel PaulMougel changed the title Selected tabs are now too white mdTabs: focused tab is now too white Jan 22, 2015
@e-oz
Copy link
Contributor

e-oz commented Jan 22, 2015

confirm, and it's critical bug.

@marcysutton
Copy link
Contributor

cc @rschmukler

@e-oz
Copy link
Contributor

e-oz commented Jan 23, 2015

bug is fixed in current code.
thanks!

@PaulMougel
Copy link
Contributor Author

@Jamm I don't think it is? The docs are built for the latest version and I can still see the issue; nor can I find a recent commit that could fix it.

@e-oz
Copy link
Contributor

e-oz commented Jan 23, 2015

I just run "bower update" on master branch, output was

bower angular-material#master               install angular-material#562d675b04

And now I don't see this bug. And it's cool. Life is good again.

@e-oz
Copy link
Contributor

e-oz commented Jan 23, 2015

@PaulMougel sorry, looks like it's fixed not for all themes (palettes). For blue it's fixed, for purple - not.

Barmen, one more tequila please.

@e-oz
Copy link
Contributor

e-oz commented Jan 24, 2015

Docs aren't updated yet, but in last freezed version (0.7.0) this bug doesn't exist. Also methods primaryPalette and accentPalette renamed back to primaryColor and accentColor (and not mentioned in changelog :P)

(this time I checked few themes before write :))

@PaulMougel
Copy link
Contributor Author

@Jamm If I'm not mistaken, that's because 0.7.0 doesn't include dd5b954 (which is responsible for this issue) and 0e0846f (which renames primaryColor to primaryPalette) ;) This release doesn't include any commit made after b432277, which was commited 9 days ago.

@naomiblack
Copy link
Contributor

@robertmesserle can you get to the bottom of whether this is fixed yet or not? I think per @PaulMougel it is, but needs a close look so we do get it in 0.7.1.

@robertmesserle
Copy link
Contributor

@rschmukler This looks like opacity is not working from theming.

https://github.com/angular/material/blob/master/src/components/tabs/tabs-theme.scss#L48

In the output CSS, both color and background-color result in the same color.

@rschmukler
Copy link
Contributor

Fixed in 72ced4b. Sorry all.

@PaulMougel
Copy link
Contributor Author

Thanks!

@e-oz
Copy link
Contributor

e-oz commented Jan 27, 2015

Love is in the air! Thanks, @rschmukler

@ThomasBurleson
Copy link
Contributor

@Jamm - LOL

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants