This repository has been archived by the owner on Sep 5, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(layouts): do not replace invalid attribute values
Do not modify attribute values with default/fallback values; only update the attrs hashmap with the fallback value. This allows components using matching directives to not lose the originating value. e.g. ```html < ui-layout layout="/api/sidebar.html" /> ``` will become ```html < ui-layout layout="/api/sidebar.html" class="layout-row" /> ```
- Loading branch information
1 parent
67ebee6
commit 16486db
Showing
2 changed files
with
7 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The side effect is that with ngMaterial the
<ui-layout class="layout-row">
will have an attached css styledisplay:flex; flex-direction:row;
... which may not be the desired.The workaround may need to be: