Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

Theme picker bugs on mobile #495

Closed
philip-firstorder opened this issue Aug 2, 2018 · 5 comments · May be fixed by #496
Closed

Theme picker bugs on mobile #495

philip-firstorder opened this issue Aug 2, 2018 · 5 comments · May be fixed by #496

Comments

@philip-firstorder
Copy link

On mobile devices (iPhone 7, iPhone X, Chrome, Safari) the theme picker doesn't automatically close.
And then if you insist in clicking it it even renders weird like in this picture.

Notice how I selected the upper left theme but theme remains the same.

Only after a full page refresh I am able to change the theme again, but after the first tap is doesn't respond anymore.

image-1

@Splaktar
Copy link
Member

I cannot reproduce this on an iPad on 13.4.1 in Chrome or Safari.

Can you please provide more details/screenshots/reproduction steps of this issue with the new theme picker?

@philip-firstorder
Copy link
Author

Here's what you need to do to reproduce it:

  1. Clear the cache of your Safari browser, so that no theme is loaded yet, this is very important because the initial loading time will cause the problem

  2. Click on the theme button, if your cache is cleared then no option is selected, which you might want to also fix by selecting a default theme
    319E65B3-D2AD-4387-B359-3D423321D52D

  3. Click on a theme, then try to change it, you should get this extra overlay to the left
    FF658396-C26C-4010-9E56-05D625055649

@Splaktar
Copy link
Member

Thank you for the additional details. I'm able to reproduce the issue with not having a default theme selected in the drop down after clearing cache.

However, I'm not able to reproduce the issue with the blank overlay on my iPad. I'll have to try an iPhone emulator.

@philip-firstorder
Copy link
Author

Yeah that's why I put at the beginning of this issue that it only appears on mobile devices (iPhone 7, iPhone X, Chrome, Safari). I don't have a tablet to test but on iMac or MacBook it doesn't happen.

I just reproduced on the xCode Simulator on my iMac, so you should also be able to debug it using the Safari Inspector.
Screenshot 2020-05-27 at 01 48 29

@amysorto
Copy link
Contributor

amysorto commented Jun 3, 2024

I cannot reproduce this issue for v18 on an iPhone, so I'm closing this issue

@amysorto amysorto closed this as completed Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants