Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MatchMediaObservable does not auto-register standard breakpoints #65

Closed
ThomasBurleson opened this issue Dec 24, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@ThomasBurleson
Copy link
Contributor

Breakpoints are registered in the BreakPointRegistry. But the MatchMediaObservable does not iterate that registry to configure the default listeners. This means only the "all" breakpoint is announced when using the observable.

@ThomasBurleson
Copy link
Contributor Author

ThomasBurleson commented Dec 24, 2016

Currently the work-around requires a manual registration process like this:

   constructor( 
     @Inject(MatchMediaObservable) media$, 
     @Inject(BreakPointRegistry) breakpoints,   // Only injected due to bug #65
     @Inject(MatchMedia) mediaWatcher,          // Only injected due to bug #65
     ) {
       
      // This is a BUG described above
      // We must manually register all the mediaQueries registered in the BreakPointRegistry
      breakpoints.items.forEach( (bp:BreakPoint) => mediaWatcher.observe(bp.mediaQuery) );
     
      this._subscription = media$
        .subscribe((change:MediaChange) => {
          let isMobile = (change.mqAlias == 'xs') || (change.mqAlias == 'sm');          
          this.isOpen = !isMobile;
      });
   }

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant