-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): support Angular 4 and AOT #255
Conversation
* Bumps all of the `@angular` dependencies to 4 and Material to 2.0.0-beta.3. * Fixes a few linter errors. * Fixes an issue that prevented AoT from working under Angular 4. * Moves away from a few of the APIs that were deprecated in Angular 4. * Fixes issues with the testing setup which prevented the module from compiling with Angular 4. * Fixes the demo app not working properly due to the Material theme not being included correctly. Fixes angular#254, angular#236, angular#227.
Presubmit error:
in |
That looks weird @jelbourn, it works for me locally. Also I did the same logic for Material 2 when I was migrating to the new renderer. |
@crisbeto Yeah, I'm not sure why this error is occurring. It only happens in one project, the rest all pass. I'll try to investigate whether they're doing something weird. |
@kara - we really need to get this merged asap! |
We are looking into a related Google test failure now. Working as fast as
we can :) promise it will be in once we can get tests passing.
…On Apr 17, 2017 8:20 PM, "Thomas Burleson" ***@***.***> wrote:
@kara <https://github.com/kara> - we really need to get this merged asap!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#255 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADsTyENNC-ND6vzbrrCEO2HB9KSS-LDdks5rxCvjgaJpZM4M7qxd>
.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@angular
dependencies to 4 and Material to 2.0.0-beta.3.BREAKING CHANGE:
These changes to @angular/flex-layout will require Angular v4.x and will not be compatible with Angular v2.x.
Fixes #254, #236, #227.